[SYCL][NFCI] Handler class ABI cleanup [1/N] #20151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR prepares for removal (once preview breaking changes are
promoted) of the following handler APIs:
- `single_task(kernel, [](){})`
- `lambdaAndKernelHaveEqualName()`
- `getKernelName()`
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sycl/source/handler.cpp
Outdated
| impl->MKernelData.setDeviceKernelInfoPtr( | ||
| &detail::ProgramManager::getInstance().getOrCreateDeviceKernelInfo( | ||
| toKernelNameStrT(getKernelName()))); | ||
| std::string(MKernel->getName()))); |
There was a problem hiding this comment.
toKernelNameStrT implementation is under preview, I'd prefer not touching its uses and leave the actual "simplification"/inlining of *KernelNameStr*T types to after all the non-preview uses are completely removed.
There was a problem hiding this comment.
toKernelNameStrTimplementation is under preview,
It can't be under preview because the code I'm changing is not under preview. I made the change because local build failed, but I've just realized that detail:: is missing
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Sep 22, 2025
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YuriPlyakhin
approved these changes
Sep 22, 2025
vinser52
approved these changes
Sep 22, 2025
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Couldn't have been caused by the PR, I will proceed with merge. The test had been already reported as hanging once: #13534 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares for removal (once preview breaking changes are promoted) of the following handler APIs:
single_task(kernel, [](){})lambdaAndKernelHaveEqualName()getKernelName()The first one was the user-visible API that was never part of the actual SYCL standard, the rest were the ABI entry points necessary to implement that API.